Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SC-1177] Deploy with create3 and save deployment #147

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

zZoMROT
Copy link
Contributor

@zZoMROT zZoMROT commented Jun 29, 2024

Static Code Analysis (readability, compactness):

Added a method to save a deployment object after deploying via create3, as hardhat-deploy does not support this and contracts deployed via create3 remain without deployments or with outdated ones. This method allows saving up-to-date deployment information.

Dynamic Code Analysis (external APIs, interaction flows):

The new method is similar to the deployAndGetContract method and is intended for deploying contracts and verifying code, but using for deploy with create3. It provides similar interaction flows and interacts with external APIs in a comparable manner.

Efficiency (gas costs, computational complexity, memory requirements):

Efficiency has not been measured as this is an auxiliary JS utility without EVM optimizations. The focus was on functionality and ease of use.

Opinion, trade-offs and other thoughts (optional):

  • The method creates a deployment object useful for further use and analysis. This facilitates the management and tracking of deployed contracts.
  • Using this method simplifies the code, making the deployment process and saving deployment information more straightforward and convenient.

Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.33%. Comparing base (971276f) to head (2999c7a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files          17       17           
  Lines         345      345           
  Branches       67       67           
=======================================
  Hits          322      322           
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZumZoom ZumZoom merged commit 2e247c2 into master Jul 3, 2024
8 checks passed
@ZumZoom ZumZoom deleted the feature/deploy-create3 branch July 3, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants