-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added the ability to create a closing entry when TODOS are marked done as per logdone #984
base: master
Are you sure you want to change the base?
Conversation
to use org-log-into-drawer setting with logdone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Nice that you also added many tests.
Unfortunately I wasn't able yet to run and test it locally. Since I last ran yarn install/start I've switched OS and now I get a lot of errors with node dependencies.
Maybe @munen has time to run a quick test?
Also, maybe we should upgrade to a newer node version...
@schoettl Did you use nvm? |
I tried but couldn't even install it on NixOS :/ I'll try again later this week. |
Hi @vHugoObject, I got my testing environment right and started playing. I like this feature, good work! For reference: I found a few bugs that you might want to fix:
I recommend that you look into how SCHEDULED and DEADLINE are implemented, it should be pretty similar regarding parsing, output, and storing. |
In reference to issue #980. There is now an option to create a closing entry when TODOS are marked done. This is disabled by default. This can be enabled in the Organice settings, for a specific file using "#+STARTUP: logdone" or for a specific header by adding ":LOGGING: logdone" as a drawer property. The default behavior when enabled is to add the closing entry to the header. However, this setting will add the closing entry to your logbook drawer if you have org-log-into-drawer enabled in the Organice settings as well. The documentation has been updated to reflect this new addition.
Fixes #980