-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade to newest Node LTS version #993
Open
munen
wants to merge
19
commits into
master
Choose a base branch
from
chore/upgrade-to-newest-node-lts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
3bb1b7c
chore: Upgrade to newest Node LTS version
munen 43cc088
Some minor upgrades
schoettl 50c9723
More minor upgrades, Dropbox login still works
schoettl 2634168
Upgrade prettier
schoettl c298823
Update browserslist db
schoettl c4e0e99
Upgrade immutable
schoettl ba67516
Upgrade dotenv
schoettl f9d6f00
Try to remove dotenv dependency
schoettl f32da67
Upgrade raw.macro
schoettl 577ccc8
Downgrade raw.macro because of bug
schoettl d33c4a7
Upgrade date-fns and fix some issues
schoettl 390bcc4
Upgrade redux and fix some issues
schoettl 1bcc23b
Upgrade react* and eslint* dependencies and fix issue
schoettl 32f7ab0
Compress SVG files with SVGO to satisfy react/babel
schoettl 0836212
Downgrade react-router-dom to v5.2.0
schoettl 1e07b0a
Fix obsolete CSS
schoettl 3c7529b
Migrate config for unmaintained babel-eslint to eslint
schoettl 5178c05
Remove unused dependencies
schoettl a0e7a68
Add some polyfills which where automatically injected by create-react…
schoettl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 12.13.1 | ||
| v20.17.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the moment, this is a workaround. Without that flag, OpenSSL has errors. On the one hand, we don't really need harder OpenSSL security defaults (I think), because we have no backend. However, introducing workarounds for legacy options is probably also not the best idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this has been introduced since node v17. So, if we cannot fix it and it is a hard problem, we could try upgrading to v16 first. However, v16 is not maintained anymore, as well. So that's not the greatest of all options..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also had this in my flake.nix. Let's see how it works out after all package upgrades.