Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --metadata take a JSON object #91

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pixelcat
Copy link

Background:

The metadata parsing as it exists today won't honor http:// schema names, which we need in order to support multiple IdP types, and specifically Microsoft Entra ID which uses schemas instead of simple strings.

As part of our implementation we store those schema names as mappings to field names in metadata, such as the following:

| Metadata        | Array                                                                                             
|                 | (                                                                                                             
|                 |     [field_email] => http://schemas.xmlsoap.org/ws/2005/05/identity/claims/emailaddress
|                 |     [field_lastName] => http://schemas.xmlsoap.org/ws/2005/05/identity/claims/surname
|                 |     [field_uniqueId] => http://schemas.microsoft.com/identity/claims/objectidentifier 
|                 |     [field_firstName] => http://schemas.xmlsoap.org/ws/2005/05/identity/claims/givenname                     
|                 | )

Solution: Instead of mapping metadata to an array based on : as a separator, this PR allows users to specify metadata as a serialized JSON string during creation or update.

@breart
Copy link
Collaborator

breart commented Sep 13, 2024

Great idea and thanks for your PR @pixelcat. I'd suggest keeping backward-compatibility, either dynamically check if JSON was provided and then treat as JSON or introduce a new option like --metadata-json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants