Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the Sankey plot : add benchmark option and adapt to the new toy data set #107

Merged
merged 8 commits into from
Apr 2, 2024

Conversation

lindadelacombaz
Copy link
Collaborator

@lindadelacombaz lindadelacombaz commented Mar 19, 2024

Closes #106.
Dear @maurolepore,

Here is a quick correction of the Sankey plot, I have realized that the changes in the new toy data set also impacted this plot. I guess it is really a good time to create more tests :-). I have not the time to create the tests this week but will do it next sprint!

Also, somehow if I do not add the _arg suffix to name my variables in my function, my data does not filter correctly.
I have no idea why it is the case, for now I have kept it like that so Anne can use the package.

Thank you !


TODO

  • Link related issue/PR.
  • Describe the goal of the PR. Avoid details that are clear in the diff.
  • Mark the PR as draft.
  • Review your own PR in "Files changed".
  • Ensure the PR branch is updated.
  • Ensure the checks pass.
  • Change the status from draft to ready.
  • Polish the PR title and description.
  • Assign a reviewer.

EXCEPTIONS

@lindadelacombaz lindadelacombaz changed the title 106 fix sankey plot Correct the Sankey plot : add benchmark option and adapt to the new toy data set Mar 19, 2024
@lindadelacombaz lindadelacombaz marked this pull request as ready for review March 19, 2024 22:04
Copy link
Contributor

@maurolepore maurolepore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. See my suggestions.

R/plot_sankey.R Show resolved Hide resolved
R/plot_sankey.R Outdated Show resolved Hide resolved
R/plot_sankey.R Outdated Show resolved Hide resolved
R/utils-custom.R Outdated Show resolved Hide resolved
@lindadelacombaz lindadelacombaz merged commit 00d0b7c into main Apr 2, 2024
6 checks passed
@lindadelacombaz lindadelacombaz deleted the 106_fix_sankey_plot branch April 2, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add benchmark choice for sankey plot and adapt to new toy data
2 participants