Correct the Sankey plot : add benchmark option and adapt to the new toy data set #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106.
Dear @maurolepore,
Here is a quick correction of the Sankey plot, I have realized that the changes in the new toy data set also impacted this plot. I guess it is really a good time to create more tests :-). I have not the time to create the tests this week but will do it next sprint!
Also, somehow if I do not add the _arg suffix to name my variables in my function, my data does not filter correctly.
I have no idea why it is the case, for now I have kept it like that so Anne can use the package.
Thank you !
TODO
EXCEPTIONS