Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create individual scatter plots for the emission and transition risks profile. #113

Merged
merged 19 commits into from
Apr 22, 2024
Merged

Create individual scatter plots for the emission and transition risks profile. #113

merged 19 commits into from
Apr 22, 2024

Conversation

lindadelacombaz
Copy link
Collaborator

@lindadelacombaz lindadelacombaz commented Apr 16, 2024 •
edited
Loading

Closes #112.
Dear @maurolepore,

I have modified and refactored my scatter plot function so that it creates individual plots for the emission and transition risk profiles.
I have also changed the code so it does not plot the SERT anymore (discussed with Anne), and averaged by each bank_id.

The creation of more robust tests will come next week, I have create a ticket for it and am in discussion with Anne for it :).

Thank you !!

TODO

  • Link related issue/PR.
  • Describe the goal of the PR. Avoid details that are clear in the diff.
  • Mark the PR as draft.
  • Include a unit test.
  • Review your own PR in "Files changed".
  • Ensure the PR branch is updated.
  • Ensure the checks pass.
  • Change the status from draft to ready.
  • Polish the PR title and description.
  • Assign a reviewer.

EXCEPTIONS

  • Slide here any item that you intentionally choose to not do.

@lindadelacombaz lindadelacombaz changed the title 112 separate scatter plot Create individual scatter plots for the emission and transition risks profile. Apr 16, 2024
@lindadelacombaz lindadelacombaz marked this pull request as ready for review April 16, 2024 18:14
maurolepore
maurolepore approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@maurolepore maurolepore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

See some suggestions.

R/scatter_plot_financial.R Show resolved Hide resolved
R/scatter_plot_financial.R Outdated Show resolved Hide resolved
R/scatter_plot_financial.R Show resolved Hide resolved
R/scatter_plot_financial.R Outdated Show resolved Hide resolved
R/utils.R Outdated Show resolved Hide resolved
R/utils.R Show resolved Hide resolved
tests/testthat/test-scatter_plot_financial.R Outdated Show resolved Hide resolved
@lindadelacombaz lindadelacombaz merged commit 9c6a7b6 into main Apr 22, 2024
6 checks passed
@lindadelacombaz lindadelacombaz deleted the 112_separate_scatter_plot branch April 22, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolepore maurolepore maurolepore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate emission and transition risks plots for the scatter plot
2 participants
@lindadelacombaz @maurolepore