Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New article shows integration with tilt system #67

Merged
merged 4 commits into from
Nov 21, 2023
Merged

New article shows integration with tilt system #67

merged 4 commits into from
Nov 21, 2023

Conversation

maurolepore
Copy link
Contributor

@maurolepore maurolepore commented Sep 13, 2023 •
edited
Loading

Closes #66
Relates to #45

This PR adds a new article showing the integration between tiltPlot and other components of the tilt system.

Goals:

  • Show that our system is already connected from end-to-end.
  • Show that "beautifying" column names breaks the connection and makes the system inconsistent.
  • Show that tiltToyData already contains toy datasets useful to tiltPlot.
  • Add an integration test (the article itself) -- that will fail when upstream components change in an incompatible way.

TODO

  • Link related issue/PR.
  • Describe the goal of the PR. Avoid details that are clear in the diff.
  • Mark the PR as draft.
  • Include a unit test.
  • Review your own PR in "Files changed".
  • Ensure the PR branch is updated.
  • Ensure the checks pass.
  • Change the status from draft to ready.
  • Polish the PR title and description.
  • Assign a reviewer.

EXCEPTIONS

  • Slide here any item that you intentionally choose to not do.

@maurolepore maurolepore marked this pull request as ready for review September 13, 2023 22:45
lindadelacombaz
lindadelacombaz approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@lindadelacombaz lindadelacombaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing ! Thank you @maurolepore and sorry for not approving these changes earlier.

@lindadelacombaz lindadelacombaz merged commit 0532b71 into main Nov 21, 2023
6 checks passed
@lindadelacombaz lindadelacombaz deleted the new-article branch November 21, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindadelacombaz lindadelacombaz lindadelacombaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show the connection between tiltPlot and tiltIndicator
2 participants
@maurolepore @lindadelacombaz