Create horizontal stacked bar charts plot without financial data #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindadelacombaz
changed the title
maurolepore
reviewed
Feb 5, 2024
There was a problem hiding this comment.
Thanks @lindadelacombaz!
Here are some comments. The most important ones are:
- Avoid exporting a new function with a name that is already deprecated.
- Avoid breaking people's code -- either by ensuring this change is backward compatible or by communicating the break clearly.
Co-authored-by: Mauro Lepore <[email protected]>
maurolepore
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
With the clarification I made I think you'll be able to make your own call and change whatever needs changing. So I approve in advance. But please don't hesitate to ask if you have more questions.
Note it would be best to first merge #79 so that the checks pass. Then merge anything else.
…lot into 81_stagger_plots
maurolepore
reviewed
Feb 13, 2024
lindadelacombaz
commented
Feb 13, 2024
| @@ -6,6 +6,7 @@ reference: | |||
|
|
|||
| - title: Main functions | |||
| contents: | |||
| - starts_with("bar_") | |||
There was a problem hiding this comment.
@maurolepore Thanks for your answer! This effectively removed the failing check(). :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81.
Dear @maurolepore,
I have created a new function that revisits the previous bar plots, as horizontal stacked bar plots instead of the vertical ones.
I know that the xctr name is depreciated, but I am waiting for the "official" toy data set so I make a large refactoring in the tiltPlot package in a subsequent PR.
Thank you for your time ! :)
TODO
EXCEPTIONS