Skip to content
build

Split interface Limiter and port default Counter from github.com/k1LoW/rlutil #145

Sign in to view logs

Split interface Limiter and port default Counter from github.com/k1LoW/rlutil

Split interface Limiter and port default Counter from github.com/k1LoW/rlutil #145

Triggered via pull request December 16, 2023 05:30
@k1LoWk1LoW
synchronize #45
separate-iface
Status Success
Total duration 1m 18s
Artifacts –

ci.yml

on: pull_request
Test
1m 9s
Test
Fit to window
Zoom out
Zoom in

Annotations

4 errors
Test: counter/counter_test.go#L24
[gostyle.errorstrings] Error strings should not be capitalized (unless beginning with proper nouns or acronyms) or end with punctuation, since they are usually printed following other context. (ref: https://github.com/golang/go/wiki/CodeReviewComments#error-strings ): "Get() = %!v(MISSING), want %!v(MISSING)"
Test: counter/counter_test.go#L38
[gostyle.errorstrings] Error strings should not be capitalized (unless beginning with proper nouns or acronyms) or end with punctuation, since they are usually printed following other context. (ref: https://github.com/golang/go/wiki/CodeReviewComments#error-strings ): "Get() = %!v(MISSING), want %!v(MISSING)"
Test: counter/counter_test.go#L59
[gostyle.errorstrings] Error strings should not be capitalized (unless beginning with proper nouns or acronyms) or end with punctuation, since they are usually printed following other context. (ref: https://github.com/golang/go/wiki/CodeReviewComments#error-strings ): "Get() = %!v(MISSING), want %!v(MISSING)"
Test: counter/counter_test.go#L81
[gostyle.errorstrings] Error strings should not be capitalized (unless beginning with proper nouns or acronyms) or end with punctuation, since they are usually printed following other context. (ref: https://github.com/golang/go/wiki/CodeReviewComments#error-strings ): "Get() = %!v(MISSING), want %!v(MISSING)"