Skip to content

Minimize the number of methods that must be implemented. #91

Minimize the number of methods that must be implemented.

Minimize the number of methods that must be implemented. #91

Triggered via pull request October 10, 2023 08:32
Status Success
Total duration 4m 5s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

8 errors and 1 warning
Test: rp.go#L15
[gostyle.ifacenames] By convention, one-method interfaces are named by the method name plus an -er suffix or similar modification to construct an agent noun. (ref: https://go.dev/doc/effective_go#interface-names ): Relayer
Test: rp.go#L28
[gostyle.ifacenames] By convention, one-method interfaces are named by the method name plus an -er suffix or similar modification to construct an agent noun. (ref: https://go.dev/doc/effective_go#interface-names ): CertGetter
Test: testutil/container.go#L141
[gostyle.handlerrors] Do not discard errors using `_` variables. If a function returns an error, check it to make sure the function succeeded. Handle the error, return it, or, in truly exceptional situations, panic. (ref: https://github.com/golang/go/wiki/CodeReviewComments#handle-errors )
Test: testutil/server.go#L14
[gostyle.handlerrors] Do not discard errors using `_` variables. If a function returns an error, check it to make sure the function succeeded. Handle the error, return it, or, in truly exceptional situations, panic. (ref: https://github.com/golang/go/wiki/CodeReviewComments#handle-errors )
Test: rp_test.go#L65
[gostyle.handlerrors] Do not discard errors using `_` variables. If a function returns an error, check it to make sure the function succeeded. Handle the error, return it, or, in truly exceptional situations, panic. (ref: https://github.com/golang/go/wiki/CodeReviewComments#handle-errors )
Test: rp_test.go#L68
[gostyle.handlerrors] Do not discard errors using `_` variables. If a function returns an error, check it to make sure the function succeeded. Handle the error, return it, or, in truly exceptional situations, panic. (ref: https://github.com/golang/go/wiki/CodeReviewComments#handle-errors )
Test: rp_test.go#L145
[gostyle.handlerrors] Do not discard errors using `_` variables. If a function returns an error, check it to make sure the function succeeded. Handle the error, return it, or, in truly exceptional situations, panic. (ref: https://github.com/golang/go/wiki/CodeReviewComments#handle-errors )
Test: rp_test.go#L196
[gostyle.handlerrors] Do not discard errors using `_` variables. If a function returns an error, check it to make sure the function succeeded. Handle the error, return it, or, in truly exceptional situations, panic. (ref: https://github.com/golang/go/wiki/CodeReviewComments#handle-errors )
Test
Restore cache failed: Dependencies file is not found in /home/runner/work/rp/rp. Supported file pattern: go.sum