More PicoVision modes #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works most of the time
Simpilfies Renderer a bit and only requires minor changes to System::update_texture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is enough to allow non-default modes by setting
DISPLAY_WIDTH/HEIGHTto the desiredhiresresolution. The next three are so you can do it at runtime (or at least try to, non-picovision returns false for anything not the defaults).Works most of the time... sometimes my mode test gets the red screen of death, but attempting to manually reproduce usually doesn't...
(+ bonus SDL cleanup because I was going to add more modes then realised it wouldn't be as simple as I thought)