feat: Update CI to only run fast tests tests in some circumstances

3box · Nov 3, 2023 · f142bbd · f142bbd
1 parent 81b7716
commit f142bbd
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 12 deletions.
diff --git a/.github/workflows/hermetic.yml b/.github/workflows/hermetic.yml
@@ -123,13 +123,14 @@ jobs:
           export TEST_NETWORK=./networks/${{ matrix.networks }}.yaml
           chmod +x ./bin/hermetic-driver
 
-          # For schedule events, "test_selector" will be null, so default to running all tests.
+          # For scheduled events, "test_selector" will be null, so default to running all tests.
           test_selector=${{ github.event.inputs.test_selector || '.' }}
-          # TODO: Uncomment once we have "fast" tests
+
           # For PR and merge group events, run only "fast" tests.
-          # if [[ ${{ github.event_name == 'pull_request' || github.event_name == 'merge_group' }} ]]; then
-          #     test_selector="fast"          
-          # fi
+          # Note it is not possible to override "test_selector" for these types of events.
+          if [[ ${{ github.event_name == 'pull_request' || github.event_name == 'merge_group' }} ]]; then
+              test_selector="fast"
+          fi
           make TEST_SELECTOR="$test_selector" HERMETIC_CMD=./bin/hermetic-driver hermetic-tests
 
   collect-results:

diff --git a/.github/workflows/schedule-durable.yml b/.github/workflows/schedule-durable.yml
@@ -91,12 +91,12 @@ jobs:
           # "workflow_dispatch" API call.
           DURABLE_TEST_BRANCH: ${{ steps.get_branch.outputs.branch }}
         run: |
-          # For schedule events, "test_selector" will be null. Run all tests for QA but only "fast" ones for other envs.
+          # For scheduled events, "test_selector" will be null. Run all tests for QA but only "fast" ones for other envs.
           test_selector=${{ github.event.inputs.test_selector || '.' }}
-          # TODO: Uncomment once we have "fast" tests
-          # if [[ -z ${{ github.event.inputs.test_selector }} ]]; then
-          #   if [[ ${{ matrix.network != 'qa' }} ]]; then
-          #     test_selector="fast"
-          #   fi
-          # fi 
+
+          if [[ -z ${{ github.event.inputs.test_selector }} ]]; then
+            if [[ ${{ matrix.network != 'qa' }} ]]; then
+              test_selector="fast"
+            fi
+          fi
           make TEST_SELECTOR="$test_selector" schedule-durable-tests