chore: fail faster if syncing events is timing out #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbrody
force-pushed
the
sync-events-timeout
branch
from
6bd539f
to
bf17952
Compare
stbrody
force-pushed
the
sync-events-timeout
branch
from
bf17952
to
49ef34a
Compare
dav1do
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
10 retries, each with a 1 minute timeout, across 2 nodes, meant that each individual test within this file took 20 minutes to fail. With 5 tests in the file, that means the test an hour and 40 minutes to fail if syncing isn't working. This felt excessive.
With this change now there's just the 1 minute timeout per node per test, so 10 minutes total to fail if things aren't working.