Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bm react 18 upgrade rwv #42

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Bianca-Morris
Copy link
Member

@Bianca-Morris Bianca-Morris commented Apr 24, 2024

Changelog:

  • Update demo viz unpkg links to react, react-dom v18
    • Slight update to how root is rendered
  • Update main package.json react, react-dom to v18
  • npm audit fix

Notes:

@Bianca-Morris Bianca-Morris marked this pull request as ready for review April 24, 2024 18:32
Copy link

@crfmc crfmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not tested locally but looks good!

Copy link
Member

@utku-ozturk utku-ozturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bianca-Morris FYI, even if the npm install and npm run dev were successful, I couldn't get it to work locally. I am getting the errors in the screenshot.

Screen Shot 2024-04-30 at 10 40 22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants