Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added portal_utils.Portal.head method #316

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Added portal_utils.Portal.head method #316

merged 6 commits into from
Aug 23, 2024

Conversation

dmichaels-harvard
Copy link
Contributor

@dmichaels-harvard dmichaels-harvard commented Aug 22, 2024 •
edited
Loading

  • Modified structured_data hook interface slightly to
    check for and call the "finish" attribute/callable hook.
  • Added portal_utils.Portal.head method.

@coveralls
Copy link

coveralls commented Aug 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10527467729

Details

  • 5 of 16 (31.25%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 75.618%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dcicutils/structured_data.py 4 6 66.67%
dcicutils/portal_utils.py 1 10 10.0%
Totals Coverage Status
Change from base Build 10479794860: -0.05%
Covered Lines: 11435
Relevant Lines: 15122
💛 - Coveralls

@dmichaels-harvard dmichaels-harvard merged commit f424018 into master Aug 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willronchetti willronchetti Awaiting requested review from willronchetti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmichaels-harvard @coveralls