Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Tinker's tool damage customization tweaks #311

Merged
merged 4 commits into from
Dec 28, 2023

Conversation

jchung01
Copy link
Contributor

On request of @sainagh, this adds the ability to tweak the hardcoded damage cutoffs for various Tinker's (and addon's) weapons. This "damage cutoff" is the value at which you start getting diminishing returns on damage over this value. You can also tweak the decay rate of the damage falloff. See the Tool Customization category under the mod integration for Tinker's for details. Others can feel free to add onto this category if desired (GameStages compat, other stat tweaks, etc).

If you would like a visualization of the damage curve, see this graph.

Also cleans up build.gradle a bit and remapping warnings when building. Fetching Industrial Foregoing wasn't behaving, so using Modrinth maven for that. Feel free to revert any changes in commit f689f2b if there's a loss in any functionality by changing remappings, but I believe it shouldn't break any tweaks.

@ACGaming
Copy link
Owner

Splendid work as usual!

Not too sure about the remapping changes though, some tweaks refused to work when disabling remapping but I‘m going to check these again before releasing future updates.

@ACGaming ACGaming merged commit f8590b5 into ACGaming:main Dec 28, 2023
1 check passed
@sainagh
Copy link

sainagh commented Dec 28, 2023

Wow! This is incredible!!

@jchung01
Copy link
Contributor Author

Splendid work as usual!

Not too sure about the remapping changes though, some tweaks refused to work when disabling remapping but I‘m going to check these again before releasing future updates.

Right, I think the warnings were caused by @At targets trying to be remapped when they aren't obfuscated (the Forestry one and MaterialAccessor in Tinkers aren't obfuscated at all). The changes should only be disabling remapping for those, but best to double check them.

@jchung01 jchung01 deleted the tinkers-tools branch January 28, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants