Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert to GregTechCEu/Buildscripts #517

Merged
merged 11 commits into from
Jul 15, 2024

Conversation

WaitingIdly
Copy link
Contributor

changes in this PR:

  • convert the current buildscripts to https://github.com/GregTechCEu/Buildscripts
  • fix nuclearcraft and simple difficulty not being testable
  • fix a large number of mods not even having their dependencies in UT.
  • add a number of boolean properties to the gradle.properties file to control if a mod is being loaded to debug UT changes.
    • this means that instead of having to search through the file and figure out which mods and library mods you need to enable to test, its a simple and easy boolean.
    • i went through and tested with each setting individually enabled and was able to launch with each debug option individually.
      • with one exception: arcane_archives requires the modid gbook_snapshot, which is only obtainable via a jar on their repo.
  • make all mods be loaded via RFG deobf
    • a side effect of this makes it so UTContainerPersonalChestMixin.java was migrated to use the relevant deobf classes (super.func_75145_c -> super.canInteractWith)

things not done in this PR:

  • setup automatic publishing
  • setup automatic formatting/spotless
  • listing the incompatibilities and dependencies for Curseforge/Modrinth
  • converting code, aside from the remap change in UTContainerPersonalChestMixin.java

note:
if you have JEI/TOP in your dev environment mods folder, you will need to remove both, as they will be added by the buildscript and thus loaded twice.

Copy link

what-the-diff bot commented Jul 14, 2024

PR Summary

  • Inclusion of Dependencies File and New Library Dependencies
    A new file named dependencies.gradle has been introduced, containing dependencies related to mods. Each mod comes with its associated debug options. Only if these debug options are true, the mod gets added in the runtimeOnly configuration. Also, this PR includes three new library dependencies enhancing different components of the software.

  • Addition and Update of Mod Details
    This update brings in the addition of the modName, modId, and modGroup properties to help in better identification of each mod. Also, changes have been made to the modVersion, includeMCVersionJar property, and modArchivesBaseName property to improve the mod performance. A debug control section for various mods has been added.

  • Update on gradle-wrapper.properties
    Made an update to 'distributionUrl' property in gradle-wrapper.properties to use Gradle 8.5, leading to better efficiency and improved performance.

  • Inclusion of Extra Repositories for Dependencies
    A repositories.gradle file has been added to incorporate additional repositories for dependencies, ensuring better resource management and efficient development process.

  • Update of Toolchains Plugin and Addition of BlowdryerSetup Plugin
    Updates have been made to the toolchains plugin, i.e., version updated to 0.7.0. A new plugin, 'blowdryerSetup,' has been added and configured to use the spotless subfolder from the GregTechCEu/Buildscripts repository.

  • Modification in UTContainerPersonalChestMixin.java
    There has been an update in the 'canInteractWith' method in the UTContainerPersonalChestMixin.java file to use modern and more efficient method names. This change aims to enhance code readability and maintainability.

@ACGaming ACGaming merged commit 716cf4f into ACGaming:main Jul 15, 2024
1 check passed
@WaitingIdly WaitingIdly deleted the gtceu-buildscript branch July 15, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants