Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update single funded channel to select inputs before sending open #2894

Closed
wants to merge 3 commits into from
Closed

Update single funded channel to select inputs before sending open #2894

wants to merge 3 commits into from

Commits on Aug 5, 2024

  1. Add optional maxExcess parameter to channel open API 

    This change passes `maxExcess` to Peer via OpenChannel and from Peer to Channel via INPUT_INIT_CHANNEL_INITIATOR. The `maxExcess` parameter will be used by bitcoind funding calls but is not currently used.
    @remyers
    remyers committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    77933ed View commit details
    Browse the repository at this point in the history

  2. Add maxExcess and addExcessToRecipientPosition params to fundTransact… 

    …ion calls

These parameters are only supported in a testing branch of bitcoind for now.
    @remyers
    remyers committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    e784ee3 View commit details
    Browse the repository at this point in the history

  3. Update single funded channel to select inputs before sending open 

     - makeFundingTx now just selects inputs and change outputs
 - (new) signFundingTx replaces the funding output script and signs
    @remyers
    remyers committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    7b8b2ae View commit details
    Browse the repository at this point in the history