Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include paymentHash in LiquidityEvent.Source #538

Closed
wants to merge 1 commit into from
Closed

Include paymentHash in LiquidityEvent.Source #538

wants to merge 1 commit into from

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Sep 22, 2023

This allows integrators to easily map events to payments.

@pm47
ìnclude paymentHash in LiquidityEvent
2c1d171 
This allows integrators to easily map events to payments.
@pm47 pm47 requested a review from dpad85 September 22, 2023 17:27
@dpad85
Copy link
Member

dpad85 commented Sep 27, 2023

Looks good. However this will require work on Phoenix side to account for the Source type change in the database.

@t-bast
Copy link
Member

t-bast commented Jul 15, 2024

I'm not sure this will be necessary once we have #649 where the payment_hash can be found in the liquidity purchase structure.

@t-bast t-bast closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpad85 dpad85 Awaiting requested review from dpad85

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pm47 @dpad85 @t-bast