Try swap-in on liquidity policy changes #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously tried swapping funds in: - at start-up - when our wallet state was updated - when a new block was found We now also check for swaps when the liquidity policy changes or the swap feerate changes.
pm47
reviewed
Oct 18, 2023
We can use the `replyTo` field to explicitly handle every failure in the splice negotiation.
pm47
approved these changes
Oct 19, 2023
Comment on lines
+1028
to
+1033
| // If the splice fails, we immediately unlock the utxos to reuse them in the next attempt. | ||
| spliceCommand.replyTo.invokeOnCompletion { ex -> | ||
| if (ex == null && spliceCommand.replyTo.getCompleted() is ChannelCommand.Commitment.Splice.Response.Failure) { | ||
| swapInCommands.trySend(SwapInCommand.UnlockWalletInputs(cmd.walletInputs.map { it.outPoint }.toSet())) | ||
| } | ||
| } |
There was a problem hiding this comment.
Nice, I envisoned something more like:
launch {
val res = spliceCommand.replyTo.await()
if (res is ChannelCommand.Commitment.Splice.Response.Failure) {
swapInCommands.trySend(SwapInCommand.UnlockWalletInputs(cmd.walletInputs.map { it.outPoint }.toSet()))
}
}But your approach has the advantage of being synchronous and removes complications around the CoroutineScope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously tried swapping funds in:
We now also check for swaps when the liquidity policy changes or the swap feerate changes.
Since this all happens inside the
Peer, we don't have good ways of unit testing it. Should we start refactoring thePeerto allow more unit testing? This will be a bit painful because of all the internal channels and flows, but may be beneficial?