Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issues #594

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Fix CI issues #594

merged 2 commits into from
Feb 8, 2024

Conversation

sstone
Copy link
Member

@sstone sstone commented Feb 7, 2024

We upgrade gradle to 8.4, which is the version of gradle used in KMP templates, and it may fix a problem we have on some Github Actions builds.
We also modify our test logger to write to stderr and not stdout, which seemed to cause problems with the processing of XML test results by our CI.

@sstone sstone requested review from dpad85 and pm47 February 7, 2024 10:45
@sstone sstone force-pushed the snapshot/update-gradle-wrapper branch from 7388fb0 to 87d472a Compare February 7, 2024 13:20
pm47
pm47 previously approved these changes Feb 7, 2024
@pm47
Copy link
Member

pm47 commented Feb 7, 2024

Wait, the last build is failing so the issue remains (and is officially flaky).

@sstone
Copy link
Member Author

sstone commented Feb 7, 2024

Our build error is related to the generation of XML result files used to report test status to CI systems, but I cannot reproduce it locally. Most builds fail but not all of them.

@sstone
Copy link
Member Author

sstone commented Feb 7, 2024

fb32db0 seems to fix our build issue

@sstone sstone requested a review from pm47 February 7, 2024 18:41
@pm47
Copy link
Member

pm47 commented Feb 8, 2024

fb32db0 seems to fix our build issue

Why would it help that logs are written to stderr instead of stdout? NB: My PR #596 was forked before the kermit commit and build still fails.

@sstone
Copy link
Member Author

sstone commented Feb 8, 2024

Because I think that the XML result files are piped from stdout and writing to it (stack traces for example) may produce invalid XML files.

@sstone
Copy link
Member Author

sstone commented Feb 8, 2024

Why would it help that logs are written to stderr instead of stdout? NB: My PR #596 was forked before the kermit commit and build still fails.

The build error in this case was different (java.lang.ArrayIndexOutOfBoundsException) and may be linked to a pb with kryo that gets fixed by upgrading gradle. It's hard to be 100% since I cannot reproduce the pb locally but in both cases (java.lang.ArrayIndexOutOfBoundsException and Cannot write XML results) the problem is not with the tests (they all pass) but with how the results are reported to the CI environment.

@sstone sstone changed the title Upgrade to gradle 8.4 Fix CI issues Feb 8, 2024
Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕯️

@sstone sstone merged commit 85395a3 into master Feb 8, 2024
4 checks passed
@sstone sstone deleted the snapshot/update-gradle-wrapper branch February 8, 2024 10:17
@pm47 pm47 mentioned this pull request Feb 15, 2024
pm47 added a commit that referenced this pull request Feb 21, 2024
Follow up to #594 which introduced deprecation warnings.

---------

Co-authored-by: Dominique Padiou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants