-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI issues #594
Fix CI issues #594
Conversation
7388fb0
to
87d472a
Compare
Wait, the last build is failing so the issue remains (and is officially flaky). |
Our build error is related to the generation of XML result files used to report test status to CI systems, but I cannot reproduce it locally. Most builds fail but not all of them. |
fb32db0 seems to fix our build issue |
Because I think that the XML result files are piped from |
The build error in this case was different ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕯️
Follow up to #594 which introduced deprecation warnings. --------- Co-authored-by: Dominique Padiou <[email protected]>
We upgrade gradle to 8.4, which is the version of gradle used in KMP templates, and it may fix a problem we have on some Github Actions builds.
We also modify our test logger to write to stderr and not stdout, which seemed to cause problems with the processing of XML test results by our CI.