Add official Dockerfile

[pm47]

Follow-up to #1.

I think building native binaries on docker is not the right approach. It's better to run on the jvm: easier build, faster runtime and compatible with linux arm64, which we don't support otherwise.

TODO:

• remove lightning-kmp build once Fix mempool.space ios tests lightning-kmp#622 is merged
• remove RUN mkdir .phoenix once Factor initialization of datadir directory #15 is merged

cc @sethforprivacy

[sethforprivacy]

Will take a deeper look asap, but at first glance I love this approach!

[tsmith123]

I'm getting "ERROR: failed to solve: eclipse-temurin:17-jre-alpine: no match for platform in manifest: not found" running on an M2 Macbook when building image.

[pm47]

Try with eclipse-temurin:21-jre-alpine Le mar. 26 mars 2024, 23:01, Tom Smith ***@***.***> a écrit :

…

I'm getting "ERROR: failed to solve: eclipse-temurin:17-jre-alpine: no match for platform in manifest: not found" running on an M2 Macbook — Reply to this email directly, view it on GitHub <#17 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPPFPRMQKUBXHNBG3FGC4LY2HO2LAVCNFSM6AAAAABFJUNRIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRRGU2DKOBQGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[tsmith123]

Changed both to 21 and it seems better but now I'm getting:

"ERROR: failed to solve: process "/bin/sh -c git clone --recursive --branch ${LIGHTNING_KMP_BRANCH} https://github.com/ACINQ/lightning-kmp . && test git rev-parse HEAD = ${LIGHTNING_KMP_COMMIT_HASH} || exit 1 && ./gradlew publishToMavenLocal -x dokkaHtml" did not complete successfully: exit code: 1"

[pm47]

Rebased on master.

Changed both to 21 and it seems better but now I'm getting:
"ERROR: failed to solve: process "/bin/sh -c git clone --recursive --branch ${LIGHTNING_KMP_BRANCH} https://github.com/ACINQ/lightning-kmp . && test git rev-parse HEAD = ${LIGHTNING_KMP_COMMIT_HASH} || exit 1 && ./gradlew publishToMavenLocal -x dokkaHtml" did not complete successfully: exit code: 1"

@tsmith123 your issue should be fixed at 5630fa0.

[sstone]

Building this docker image still won't work on macOS arm64 because of gradle/gradle#24875.
It could be fixed by using a glibc-based distro (ubuntu, ...) or maybe switching to a snapshot version of gradle 8.8 but I'm not sure it's worth it as macOS arm64 is not a production target (and we already publish a native phoenixd exe for macOS arm64).

[pm47]

So @sstone should work on all 4 combinations linux/macos x64/arm64?

More portability is better for docker I think. Besides, ubuntu 21 + jdk21 seems tailor made for a bitcoin app 😄

[pm47]

Actually went back to alpine for the final image. Best of both worlds or over the top?

[sethforprivacy]

Dockerfile looks GTG to me, fantasticly simplified approach compared to building from source.

I'll switch to using this as well in mine (will keep my repo just so there can be a published image in GHCR/Dockerhub) with proper credit, of course. Thanks for all of the work on this @pm47!

[sethforprivacy]

I have a few other minor improvements (none necessary, just tweaks and more explicit declaration of things like user:group pairings) in my PR on my own repo here, feel free to take anything that strikes your fancy, no credit etc. necessary.

sethforprivacy/phoenixd-docker#3

[sethforprivacy]

Sorry for the message spam, but I actually just caught a breaking issue with the proposed Dockerfile. This Dockerfile doesn't properly set the file permissions for /phoenix which can sometimes cause the image to error out with a permissions issue when run.

See the fix here: sethforprivacy/phoenixd-docker@f3a63e0

[sethforprivacy]

@pm47 seems there is a build issue for ARMv8, can't get it to find a workable Kotlin version. Logs:

https://paste.sethforprivacy.com/?ddbbbdc28345c06d#4DPdDZvXT4CGRBJ7jo1CDnNTUB3Ynkvp5yuMRcMJ3iqX

Not sure if you can access it, but the full Github Action run is here: https://github.com/sethforprivacy/phoenixd-docker/actions/runs/8457575444/job/23169856878?pr=3

Edit: Nevermind, seems you can't build ARMv8 using ARMv8 due to Kotlin having no native aarch64 Linux support. Will find another way to distribute ARMv8 images then.

[pm47]

Edit: Nevermind, seems you can't build ARMv8 using ARMv8 due to Kotlin having no native aarch64 Linux support. Will find another way to distribute ARMv8 images then.

On the contrary, it should work, that is the point of using a jvm build for docker instead of a native one. Seems like gradle tries to build the native version, which we are not going to use anyway.

Will look at your other changes, feel free to suggest changes directly on this PR too!

[sethforprivacy]

I think this encompasses all of my minor changes/improvements, feel free to take or leave any and all of them as you see fit :)

[sethforprivacy]

Better apt cleanup:

Suggested change

	&& apt clean
	&& apt clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

[sstone]

Building phoenixd in docker is hard and there does not seem to be a way to make it work for linux/arm64 (which would be a real production target), even if issues with gradle on alpine are solved.
Why not remove the build step and have the docker file simply download the released JVM binaries and use them directly ? that would give us a simple docker file that would work on all targets the JVM version supports (including macos arm64/x64 and linux arm64/x64) ?

[sstone]

Building phoenixd in docker is hard and there does not seem to be a way to make it work for linux/arm64

@pm47 found a workaround (see #25)

[pm47]

@sethforprivacy the build should pass on arm at 75247e4 (current master tip)

[sethforprivacy]

@sethforprivacy the build should pass on arm at 75247e4 (current master tip)

Testing now! https://github.com/sethforprivacy/phoenixd-docker/actions/runs/8468177452/job/23200542411?pr=3

[sethforprivacy]

@sethforprivacy the build should pass on arm at 75247e4 (current master tip)

Builds are working on ARMv8 now!

[pm47]

Looking pretty good I think. Will update branch/version after next release

[tsmith123]

Not sure if this Dockerfile is in its final state yet but it doesn't work for me on an M2 Macbook.

[sethforprivacy]

Not sure if this Dockerfile is in its final state yet but it doesn't work for me on an M2 Macbook.

This issue was fixed in master, so next release will include the fix (per #17 (comment)). It was discussed at length above if you want more details on it!

[pm47]

@tsmith123 Please confirm you are getting this error when using the Dockerfile at commit f255a11.

[dnjooiopa]

@tsmith123 Please confirm you are getting this error when using the Dockerfile at commit f255a11.

I got the same error on an M1 MacBook.
Commit f255a11

[pm47]

@tsmith123 @dnjooiopa Please try again at 1c3a7ab thanks!

[dnjooiopa]

@tsmith123 @dnjooiopa Please try again at 1c3a7ab thanks!

Great! Docker is now successfully built on my M1 Mac.

[sethforprivacy]

Amazing work on this, thank you @pm47! I've merged a very similar Dockerfile with automatic builds via Github Actions, so anyone who wants to use a ready-built image for phoenixd can use it easily:

https://github.com/sethforprivacy/phoenixd-docker/pkgs/container/phoenixd

The latest v0.1.4 version is building now and will be available shortly.