Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify musig2 secret nonces #108

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Verify musig2 secret nonces #108

merged 5 commits into from
Apr 18, 2024

Commits on Apr 16, 2024

  1. Verify musig2 secret nonces

    Trying to generate a musig2 partial signature with a secret nonce that was generated with a public key that does not match the
    siging key's public key will trigger secp256k1's illegal callback (which calls abort()) and crash the application.
    
    => Here we verify that the secret nonce matches the siging keys before we call secp256k1_musig_partial_sign().
    The verification method is a bit hackish (we extract the public key from the secret nonce blob) because secp256k1 does not export the methods we need
    to do this cleanly.
    sstone committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e532ad8 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Address review comments

    sstone committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2732f67 View commit details
    Browse the repository at this point in the history
  2. Fixup! remove empty line

    sstone committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    3404542 View commit details
    Browse the repository at this point in the history
  3. fixup! Address review comments

    sstone committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    a1ddfde View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    384cdc2 View commit details
    Browse the repository at this point in the history