Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check arguments passed to secp256k1 methods #94

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Check arguments passed to secp256k1 methods #94

merged 3 commits into from
Dec 13, 2023

Commits on Dec 13, 2023

  1. Set version to 0.12.0-SNAPSHOT

    @sstone
    sstone committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    af96156 View commit details
    Browse the repository at this point in the history

  2. Check arguments passed to secp256k1 methods 

    Illegal arguments will trigger an internal callback that prints to stderr and calls abort.
We already check arguments in our JNI and kotlin native code but had missed 2 checks (recid in ecdsaRecover, empty arrays in pubkeyCombine).
    @sstone
    sstone committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    f8f1356 View commit details
    Browse the repository at this point in the history

  3. Implement the same "tweak" checks in the native code and JNI code 

    The native code was missing checks on the "tweak" size (which must be 32 bytes)
    @sstone
    sstone committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    8010f4f View commit details
    Browse the repository at this point in the history