Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix locking mode in interface #478

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix locking mode in interface #478

wants to merge 2 commits into from

Conversation

GlodBlock
Copy link

close #476

@zeng-github01
Copy link

zeng-github01 commented Jul 13, 2024

@GlodBlock 你改了流体接口的流体触发器嘛?我给流体也加了一个类似的触发器。用来给隔壁的AE2FC适配的。忘记改的话可能二合一接口要出问题。我怕你把流体接口也改了...

看起来流体接口没有改,还是用了原来的逻辑的样子

Did you make similar changes to the fluid interface? There is an support for AE2FC in Lock Crafting PR. If so, please don't forget to fix it as well.

commit

@GlodBlock
Copy link
Author

明天弄

@zeng-github01
Copy link

zeng-github01 commented Jul 14, 2024

明天弄

OK,还好管理员还没合并。合并了想再打补丁就有点难了。而且现有的构建Action有点毛病。不知道为什么它的版本号被Forge识别成了无效的。我交了个PR临时修复了一下

顺便现有的修复方案还能再改改。可以不考虑重新调用那个触发器了。接口Tile里面不是还有一个实际功能的Tile类吗 那个类里面有一个OnStackReturnNetwork(IAEItemStack) 的方法。那个是实际的解锁函数。你看看能不能直接call到这个函数。省的重新用那个InventoryChange了。要是Call不到的话TileInterface里面也有一个嵌套的实现。直接Call那个也行,正好那个还是接口方法。不是具体实现。还能解耦。

至于流体接口,也有一个同名的解锁函数。但是在流体接口的内部实现类里面没有实现。FluidChange是直接调用的上层IFluidInterfaceHost的接口方法。毕竟流体接口没需求 只是留个位置给AE2FC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lock Crafting Broken on latest build
2 participants