-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(MA-88): more developer information #164
base: stable
Are you sure you want to change the base?
Conversation
introduction to pgadmin, git, proposal for a working setup with submodules and subfolders.
|
||
### Local repositories' organization on the filesystem | ||
|
||
The `MyAEGEE` repository contains several git submodules. Submodules are roughly pointers to specific versions of other git repositories. You will most probably **not** commit to the current repository, but you will rather make edits on the frontend, events, or discounts repositories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you only mention frontend, events and discounts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"such as" would be a better wording indeed.
#PATH_STATUTORY=myRepoClones/statutory/docker | ||
``` | ||
|
||
With this setup, you can easily override the code running in production (= the code in the submodules) with the one you have locally (the repos in `myRepoClones`). Having duplicated keys in a `.env` will be displayed as a warning in your IDE, so you will notice through IDE warnings when you are overriding repositories and when you are using the version in production. In the example above, I'm using my own version of events and frontend, but the prod version of statutory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you want to use this? I think it is easier to just use the code from the submodules (but pulled to master ofc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the submodules were always up to date. Indeed, if we need to update the subrepos ourselves, the setup I describe does not bring a lot of advantages.
|
||
### Update the local repositories | ||
|
||
Changes happen on all the repositories, and while breaking changes are the exception rather than the norm, it is good practise to update all your repositories every once in a while, especially the `MyAEGEE` one, since it's the one running in production. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MyAEGEE repo is not the same as running in production. But might we could do something that with every release of a submodule a PR is made in the MyAEGEE repo
|
||
### Development tools | ||
|
||
#### IDE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add something about ESLint and editorconfig?
- myaegee_postgres-discounts_1 | ||
- myaegee_postgres-events_1 | ||
|
||
In the pgadmin UI, you must thus create four servers to read all the data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not done automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fabri could answer this. But frankly, creating those connections manually is not a problem. And you need to have the use to look at or change the DB content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's just no way to provision them (at least as of 1st october 2020 :D )
Bumps [jest](https://github.com/facebook/jest) from 26.6.1 to 26.6.3. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md) - [Commits](jestjs/jest@v26.6.1...v26.6.3) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
introduction to pgadmin, git, proposal for a working setup with submodules
and subfolders.
Needs edition around bumping of submodules.
make bump
: to be run on the host? After doing a recursive pull?