Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ids to tests via pytest.param #30

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Adds ids to tests via pytest.param #30

merged 1 commit into from
Feb 21, 2024

Conversation

ns-rse
Copy link
Collaborator

@ns-rse ns-rse commented Jan 1, 2024

I discovered pytest.param() which allows parameter sets to be given ids and thought it a simple but useful habit to start using.

Another useful option is the marks= so particular parameters can be marked to fail, or be skipped if certain conditions are met, but these aren't needed here.

@ns-rse ns-rse added the testing Problems with testing label Jan 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f282c31) 65.87% compared to head (a2faedb) 65.87%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   65.87%   65.87%           
=======================================
  Files           3        3           
  Lines         337      337           
=======================================
  Hits          222      222           
  Misses        115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@SylviaWhittle SylviaWhittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice! Something I didn't know that I desperately needed!

@ns-rse ns-rse merged commit 72fa1bf into main Feb 21, 2024
10 checks passed
@ns-rse ns-rse deleted the ns-rse/pytest-param branch February 21, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Problems with testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants