Make the renaming of TrackerHit -> TrackerHit3D transparent #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Test Results 6 files 6 suites 2h 43m 37s ⏱️ Results for commit 9f86375. ♻️ This comment has been updated with latest results. |
|
@tmadlener Should I merge ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
edm4hep::TrackerHittoedm4hep::TrackerHit3D(Use interface types for TrackerHit key4hep/EDM4hep#252) transparent as far as DD4hep is concerned.ENDRELEASENOTES
I am using the existence of the new header file to detect which version of the TrackerHit to use and just typedef to the new type name in case it's not yet present. In my local testing this works for current EDM4hep as well as for the version with the above PR merged.