Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i2c_smbus_read_i2c_block_data return value check #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

illiav-j
Copy link

@illiav-j illiav-j commented Jun 26, 2024

Fixes the error when trying to build on the latest OpenBMC:

| …/src/vr_update_mps.cpp: In member function 'virtual bool vr_update_mps::crcCheckSum()':
| …/src/vr_update_mps.cpp:32:15: error: ordered comparison of pointer with integer zero ('uint8_t*' {aka 'unsigned char*'} and 'int')
|    32 |     if (rdata < SUCCESS)
| …/src/vr_update_mps.cpp: In member function 'virtual bool vr_update_mps::isUpdatable()':
| …/src/vr_update_mps.cpp:83:14: error: ordered comparison of pointer with integer zero ('uint8_t*' {aka 'unsigned char*'} and 'int')
|    83 |     if(rdata >= SUCCESS)
| …/src/vr_update_mps.cpp:95:14: error: ordered comparison of pointer with integer zero ('uint8_t*' {aka 'unsigned char*'} and 'int')
|    95 |     if(rdata >= SUCCESS)

This change has not been tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant