Particles: More Specializations #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a few more template specializations as used in ImpactX and HiPACE++ particle containers.
This was referenced Jul 22, 2022
ax3l
commented
Jul 22, 2022
| @@ -80,7 +80,8 @@ void make_ArrayOfStructs(py::module &m) | |||
| } | |||
|
|
|||
| void init_ArrayOfStructs(py::module& m) { | |||
| make_ArrayOfStructs<7,0> (m); | |||
| make_ArrayOfStructs< 0, 0> (m); | |||
There was a problem hiding this comment.
@RTSandberg this one should cause no problems, does it?
make_ArrayOfStructs< 0, 0> (m);
There was a problem hiding this comment.
I can't think of any reason it should cause problems, we even have some tests in place to keep the user from accidentally referencing non-existent real or int data
RTSandberg
reviewed
Jul 23, 2022
| @@ -80,7 +80,8 @@ void make_ArrayOfStructs(py::module &m) | |||
| } | |||
|
|
|||
| void init_ArrayOfStructs(py::module& m) { | |||
| make_ArrayOfStructs<7,0> (m); | |||
| make_ArrayOfStructs< 0, 0> (m); | |||
There was a problem hiding this comment.
I can't think of any reason it should cause problems, we even have some tests in place to keep the user from accidentally referencing non-existent real or int data
| make_Particle< 3, 2 > (m); | ||
| make_Particle< 4, 0 > (m); // HiPACE++ 22.07 | ||
| make_Particle< 5, 0 > (m); // ImpactX 22.07 | ||
| make_Particle< 37, 1> (m); // HiPACE++ 22.07 |
There was a problem hiding this comment.
Thanks for the comments indicating which versions are for which codes
There was a problem hiding this comment.
Sure thing, thanks :)
Thank you for documenting the task in #49 as well ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few more template specializations as used in ImpactX and HiPACE++ particle containers.