Unbreak -DAVIF_BUILD_GDK_PIXBUF=ON build #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreeBSD by default only looks for headers/libraries in base system, so depending on packages requires passing -isystem + -L or relying on pkg-config. FAILED: contrib/gdk-pixbuf/libpixbufloader-avif.so : && /usr/bin/cc -fPIC -shared -o contrib/gdk-pixbuf/libpixbufloader-avif.so contrib/gdk-pixbuf/CMakeFiles/pixbufloader-avif.dir/loader.c.o -Wl,-rpath,/tmp/libavif_build: -lgdk_pixbuf-2.0 -lgobject-2.0 -lglib-2.0 -lintl libavif.so.16.0.0 && : ld: error: unable to find library -lgdk_pixbuf-2.0 ld: error: unable to find library -lgobject-2.0 ld: error: unable to find library -lglib-2.0 ld: error: unable to find library -lintl cc: error: linker command failed with exit code 1 (use -v to see invocation)
contrib/gdk-pixbuf/loader.c:212:29: error: no member named 'mode' in 'struct avifImageMirror'
switch (image->imir.mode) {
~~~~~~~~~~~ ^
This reverts commit 0f729c1.
wantehchang
approved these changes
Aug 28, 2023
| @@ -11,6 +11,7 @@ if(AVIF_BUILD_GDK_PIXBUF) | |||
| add_library(pixbufloader-avif MODULE ${GDK_PIXBUF_SRCS}) | |||
|
|
|||
| target_link_libraries(pixbufloader-avif PUBLIC ${GDK_PIXBUF_LIBRARIES} avif) | |||
| target_link_directories(pixbufloader-avif PUBLIC ${GDK_PIXBUF_LIBRARY_DIRS}) | |||
There was a problem hiding this comment.
@novomesk Daniel, could you take a look at this change?
|
We will create a libavif 1.0.1 release to fix the -DAVIF_BUILD_GDK_PIXBUF=ON build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1509 regression and apply part of #296 still required on BSDs.