Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cifuzz.yml on pull requests for CMakeLists.txt #2361

Conversation

wantehchang
Copy link
Collaborator

All the other CI workflows that run on pull requests for 'cmake/**' also run on pull requests for '**CMakeLists.txt'. So cifuzz.yml is the only exception.

All the other CI workflows that run on pull requests for 'cmake/**' also
run on pull requests for '**CMakeLists.txt'. So cifuzz.yml is the only
exception.
@y-guyon
Copy link
Collaborator

y-guyon commented Aug 1, 2024

All the other CI workflows that run on pull requests for 'cmake/**' also run on pull requests for '**CMakeLists.txt'. So cifuzz.yml is the only exception.

This may be expected. Most CI workflows make sure the targets build and the tests pass. Fuzzing on the other hand is focused on finding implementation bugs. Up to you.

@wantehchang
Copy link
Collaborator Author

Our build system is comprised of '**CMakeLists.txt' and 'cmake/**', so it makes sense to give them the same treatment.

@wantehchang wantehchang merged commit 9caff7a into AOMediaCodec:main Aug 1, 2024
15 checks passed
@wantehchang wantehchang deleted the run-cifuzz-workflow-on-cmakelists-changes branch August 1, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants