Fix empty CMAKE_CXX_FLAGS_RELEASE if libaom local #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzern
approved these changes
Aug 5, 2024
wantehchang
force-pushed
the
fdintino-unset-aom-cache-variables
branch
from
6c9f61c
to
7524d87
Compare
Fix empty CMAKE_CXX_FLAGS_RELEASE if libaom is built locally using FetchContent and AVIF_LIBYUV is OFF. libaom sets CMAKE_CXX_FLAGS_RELEASE and other flags as CACHE variables. To undo the changes libaom makes, unset the variables as cache variables so that they can be reset to their original values as normal variables. Fix AOMediaCodec#2365.
wantehchang
force-pushed
the
fdintino-unset-aom-cache-variables
branch
from
7524d87
to
cb8cd94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix empty CMAKE_CXX_FLAGS_RELEASE if libaom is built locally using FetchContent and AVIF_LIBYUV is OFF.
libaom sets CMAKE_CXX_FLAGS_RELEASE and other flags as CACHE variables. To undo the changes libaom makes, unset the variables as cache variables so that they can be reset to their original values as normal variables.
Fix #2365.