AVIF_ENABLE_EXPERIMENTAL_MINI instead of METAV1 #2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the experimental prototype implementation to the latest specification draft.
To avoid Windows MSVC warning C4701: potentially uninitialized local variable used
wantehchang
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
LGTM. Thanks again for revising the spec and the implementation!
I only skimmed through the pull request and made sure it is a no-op if the experimental feature is disabled. I'd like to read it again and compare with the spec, because that's usually when I actually review the spec carefully, but I think it is fine to merge this PR first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the experimental prototype implementation to the latest specification draft.