-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty HandlerBox name instead of "libavif" #2378
Conversation
include/avif/avif.h
Outdated
@@ -216,6 +216,8 @@ typedef enum avifHeaderFormat | |||
{ | |||
// AVIF file with an "avif" brand, a MetaBox and all its required boxes for maximum compatibility. | |||
AVIF_HEADER_FULL, | |||
// Same as AVIF_HEADER_FULL but the name field of the HandlerBox is empty instead of "libavif". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be better to always write an empty handler name so that we can avoid adding a new encoder option. (This new enum variant is equivalent to a new boolean option.) Most of our clients use our defaults, so they will experience the change of behavior.
One way to justify this is that "libavif" is not really a track type.
I checked libheif. It does not seem to write the handler name. The call in libheif/libheif/context.cc is commented out:
// TODO: the hdlr box is not the right place for comments
// m_heif_file->set_hdlr_library_info(encoder->plugin->get_plugin_name());
It would be good to inspect HEIC photos taken by an iPhone and see what their handler name field is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leo-barnes Leo: This is the libavif HandlerBox name issue I mentioned at the end of the AOMedia Image Container subgroup meeting today.
Yannis: I suggest we make this change without adding a new AVIF header format option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that Apple platforms create HEIF files with empty handler name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yannis: I suggest we make this change without adding a new AVIF header format option.
Done. PTAL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks. I suggest some changes.
Empty HandlerBox name by default.