Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent system time changes from affecting timeouts, other misc changes. #51

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

catwood
Copy link
Contributor

@catwood catwood commented May 8, 2014

Here are some changes that I have been sitting on for a while. The monotonic clock change was inspired when someone changed the system time on my server backwards a bit ... which caused havoc with the timeouts in my APEServer javascript code. I have had the clock changes running on my production server for about 2 months now, the other changes for over a year.

@lcharette
Copy link
Collaborator

Never experienced this clock bug, but nice find. I’ll test it out, but since I’m not a C expert, if someone else can confirm everything is fine I can probably merge that no problem.

Thanks!

Le 2014-05-08 à 15:32, Cliff Atwood [email protected] a écrit :

Here are some changes that I have been sitting on for a while. The monotonic clock change was inspired when someone changed the system time on my server backwards a bit ... which caused havoc with the timeouts in my APEServer javascript code. I have had the clock changes running on my production server for about 2 months now, the other changes for over a year.

You can merge this Pull Request by running

git pull https://github.com/catwood/APE_Server master
Or view, comment on, or merge it at:

#51

Commit Summary

Use monotonic clock to avoid issues with clock time changes
Replace some pointers with NULL after heap freed
Use safe_shutdown vs shutdown
Add missing urldecode of JSON string values
Resolve merge conflicts
File Changes

M Makefile (2)
M modules/libape-spidermonkey.c (6)
M src/http.c (2)
M src/json_parser.c (7)
M src/sock.c (34)
Patch Links:

https://github.com/APE-Project/APE_Server/pull/51.patch
https://github.com/APE-Project/APE_Server/pull/51.diff

Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants