Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependency on major 1 of greentea-client #182

Merged
merged 1 commit into from
Mar 16, 2016

Conversation

bogdanm
Copy link
Contributor

@bogdanm bogdanm commented Mar 16, 2016

No description provided.

@bogdanm
Copy link
Contributor Author

bogdanm commented Mar 16, 2016

Major version 1 of greentea-client might not be published yet, but this change is backwards compatible.
The intention is to release a new minor version of this module once this PR is merged.
@0xc0170 @bremoran

@bremoran
Copy link
Collaborator

-1. This should be a test dependency. Fixing this problem will fix the failures in other modules.

@bogdanm
Copy link
Contributor Author

bogdanm commented Mar 16, 2016

This one is a regular dependency: https://github.com/ARMmbed/mbed-drivers/blob/master/source/retarget.cpp#L74

@bremoran
Copy link
Collaborator

https://github.com/ARMmbed/mbed-drivers/blob/master/source/retarget.cpp#L73 ensures that it is only used if the module is present in the build. This is still a test dependency.

@bogdanm
Copy link
Contributor Author

bogdanm commented Mar 16, 2016

I'm sorry, but I believe it's too risky to make this into a test dependency right now (in the context of the release), because I don't know what could break if we do so. Feel free to open a separate issue for this.

@bogdanm
Copy link
Contributor Author

bogdanm commented Mar 16, 2016

Merging as it is for now. @bremoran opened #183 to track this.

bogdanm added a commit that referenced this pull request Mar 16, 2016
Updated dependency on major 1 of greentea-client
@bogdanm bogdanm merged commit ddce4ec into master Mar 16, 2016
@bogdanm bogdanm deleted the update_greentea_dep branch March 16, 2016 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants