Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the tls-client README.md #229

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update the tls-client README.md #229

wants to merge 2 commits into from

Conversation

RonEld
Copy link
Contributor

@RonEld RonEld commented Jan 10, 2019

Update the tls-client application README.md as
it mentions EasyConnect, and it is not true anymore. Update the links as
well.
Fixes #228

Copy link
Contributor

@k-stachowiak k-stachowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RonEld Can you please explain the additional changes provided with this PR? I know that the data needed for the public access have changed, so I was expecting the changes to address that, however, it is not clear from the commit, why they were introduced.

I built and ran the example and I confirm that it still works, so I approve the PR in principle. However, I think it would be better for the sake of tracking the changes to split this PR into two commits with descriptive messages.

Ron Eldor added 2 commits January 14, 2019 12:00
Update the tls-client application `README.md` as
it mentions EasyConnect, and it is not true anymore.
Update links to a current location.
@RonEld
Copy link
Contributor Author

RonEld commented Jan 14, 2019

@k-stachowiak Thank yo for your review!

I have split the commit to two, per your suggestion.

@k-stachowiak
Copy link
Contributor

@RonEld Thank you for addressing that. I still approve the PR.

@AndrzejKurek
Copy link
Contributor

AndrzejKurek commented Mar 1, 2019

@sbutcher-arm - please review this PR, as it is targeted for 19.02.

@JanneKiiskila
Copy link
Contributor

Bump @sbutcher-arm @k-stachowiak , you should merge this in...

@simonbutcher simonbutcher removed their request for review November 10, 2020 14:51
@simonbutcher
Copy link
Contributor

Nothing to do with me @JanneKiiskila, nor @k-stachowiak. We don't work on this. In actual fact, I think ownership has passed hands two or three times since this PR was opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The README.md says the TLS example uses Easy Connect
5 participants