Add sharedConsumer test cases. #55
Conversation
There was a problem hiding this comment.
The new added test case is perfect to me. However, sorry I just noticed that it's unacceptable to use higher major version of openzeppelin-contracts-upgradeable which is greater than 4.x.x.
As openzeppelin says in the latest README.md, "For upgradeable contracts, the storage layout of different major versions should be assumed incompatible". We can affirm that for example, the way to implement OwnableUpgradeable.sol between 4.x.x and 5.x.x is totally different, which will disrupt the global variable layout, tending to make irreversible results(say we upgrade Adapter.sol and do some interactions).
Actually it's ok to use the latest openzeppelin-contracts-upgradeable on user contracts, but since we still need to test them in the main repo, let's keep the same library version. Please modify this pr and submit a pr for relevant changes on https://github.com/ARPA-Network/Randcast-User-Contract.
Andlyn666
force-pushed
the
playground
branch
from
1546ebe
to
2a6e8a1
Compare
Andlyn666
force-pushed
the
playground
branch
from
c055a4d
to
c54f65a
Compare
No description provided.