Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update m11/m12 calculation in S1 correction workflow #281

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Update m11/m12 calculation in S1 correction workflow #281

merged 1 commit into from
Jul 3, 2024

Conversation

jhkennedy
Copy link
Contributor

@jhkennedy jhkennedy commented Jul 3, 2024 •
edited
Loading

  • Switches to writing ints for m11/m12 just like the autoRIFT velocity products.
  • Drops unused portions of the workflow

@jhkennedy jhkennedy added the bumpless Changes to documentation, CI/CD pipelines, etc that don't affect the project's version label Jul 3, 2024
@jhkennedy jhkennedy marked this pull request as ready for review July 3, 2024 06:20
@jhkennedy jhkennedy requested a review from a team as a code owner July 3, 2024 06:20
mfangaritav
mfangaritav approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@mfangaritav mfangaritav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the s1_correction workflow and the outputs look fine.

@jhkennedy jhkennedy merged commit 035115f into develop Jul 3, 2024
6 of 7 checks passed
@jhkennedy jhkennedy deleted the m11m12 branch July 3, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfangaritav mfangaritav mfangaritav approved these changes

Assignees
No one assigned
Labels
bumpless Changes to documentation, CI/CD pipelines, etc that don't affect the project's version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhkennedy @mfangaritav