-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 6.4.1 #517
Merged
Merged
Release 6.4.1 #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [aws-actions/amazon-ecr-login](https://github.com/aws-actions/amazon-ecr-login) from 1 to 2. - [Release notes](https://github.com/aws-actions/amazon-ecr-login/releases) - [Changelog](https://github.com/aws-actions/amazon-ecr-login/blob/main/CHANGELOG.md) - [Commits](aws-actions/amazon-ecr-login@v1...v2) --- updated-dependencies: - dependency-name: aws-actions/amazon-ecr-login dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…tions/amazon-ecr-login-2 Bump aws-actions/amazon-ecr-login from 1 to 2
… work, modify the create_water_mask function to corrrect wrong mask shapefile and make the gdal.rasteize work
need libspatialindex-dev and rtree library to make the geopandas.clip…
Fixed Errors in Water Masking Over Europe
add s3fs to requirements
Co-authored-by: Andrew Player <[email protected]>
add shapely>=2.0 in the setup.py and environment.yml
need to add libspatialindex-dev and rtree for making the geopandas.cl…
…e, add clip with extent
…t, solve the antimeridian issue
back to the previous way of reasding the mask with geopandas.read_fil…
Fix Errors in Water Masking
…o read_file and clip with the envelope of extent
Co-authored-by: Andrew Player <[email protected]>
…ut reference file projection
do not split the antimeridian extent, but convert it into UTM, then d…
Developer checklist
Reviewer checklist
|
Removed Unnecessary Imports
Docstring Fix
cirrusasf
reviewed
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest for CHANGELOG.md "Use envelope of input file in its projection to create water mask to overcome antimeridian and significantly incorrect over some regions in Europe" . please re wording this, but I would like to include actual change for this release
Better Changelog for Release 6.4.1
cirrusasf
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.