Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v8.2.0 #580

Merged
merged 9 commits into from
Jul 17, 2024
Merged

Release v8.2.0 #580

merged 9 commits into from
Jul 17, 2024

Conversation

forrestfwilliams
Copy link
Contributor

@forrestfwilliams forrestfwilliams commented Jul 9, 2024

Update to Gamma v20231208.

Golden RTC tests here, golden InSAR tests here.

@forrestfwilliams forrestfwilliams added the minor Bump the minor version number of this project label Jul 9, 2024
@forrestfwilliams forrestfwilliams requested a review from a team as a code owner July 9, 2024 13:16
Copy link

github-actions bot commented Jul 9, 2024

Developer checklist

  • Indicated the level of changes to this package by affixing one of these labels:
    • major -- Major changes to the API that may break current workflows
    • minor -- Minor changes to the API that do not break current workflows
    • patch -- Patches and bugfixes for the current version that do not break current workflows
    • bumpless -- Changes to documentation, CI/CD pipelines, etc. that don't affect the software's version
  • (If applicable) Updated the dependencies and indicated any downstream changes that are required
  • Added/updated documentation for these changes
  • Added/updated tests for these changes
  • Verified changes in test deployment and summarized results, e.g. in PR description or comments on the related issue(s)

Reviewer checklist

  • Have all dependencies been updated?
  • Is the level of changes labeled appropriately?
  • Are all the changes described appropriately in CHANGELOG.md?
  • Has the documentation been adequately updated?
  • Are the tests adequate?
  • Have the changes been verified in the test deployment?

@forrestfwilliams
Copy link
Contributor Author

Checked the failing RTC golden tests, main failures seem to be in area products (likely related to updates in the dem_gradient changes mentioned in the release). No significant issues found, happy with RTC.

@forrestfwilliams
Copy link
Contributor Author

There is a clear phase ramp difference in the unw_phase products for all of our test InSAR sites. I've included an example from the Ridgecrest EQ golden test and am investigating the source.
unw_phase

@forrestfwilliams
Copy link
Contributor Author

Holding off for now until we can decide what to do about the ramping issue.

@forrestfwilliams forrestfwilliams marked this pull request as draft July 12, 2024 15:27
Update to gamma 20240627 instead
@forrestfwilliams
Copy link
Contributor Author

Explored the ramp issue in the newest Gamma version (v20240627). Found that it was still present, but to a lesser extent. This issue is unlikely to affect scientific analyses performed using the InSAR data, so I recommend proceeding with the upgrade.

@forrestfwilliams forrestfwilliams marked this pull request as ready for review July 17, 2024 13:21
@forrestfwilliams forrestfwilliams merged commit 55093fe into main Jul 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Bump the minor version number of this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants