Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

early draft of post-unwrapping water masking #107

Merged
merged 14 commits into from
Jul 12, 2023
Merged

Conversation

asjohnston-asf
Copy link
Member

@asjohnston-asf asjohnston-asf commented Jul 6, 2023

water_mask.py and test_water_mask.py are duplicated from hyp3-gamma

TODO

  • apply water mask before creating browse image
  • update changelog
  • add water masking content to README.md.txt

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
/home/runner/micromamba-root/envs/hyp3-isce2/lib/python3.11/site-packages/hyp3_isce2
   __main__.py26292%33, 44
   burst.py1465165%78–81, 94–99, 113–128, 144–153, 167–177, 235, 282–290, 310–324
   insar_stripmap.py341362%40, 57–75
   insar_tops.py562850%51–84, 105–125
   insar_tops_burst.py18914523%69–113, 125–150, 179–256, 267–349, 361–362, 390–466
   logging.py4175%9
   s1_auxcal.py21290%51, 59
   slc.py341071%22–25, 29–34
   topsapp.py69888%74, 104, 126–132
   utils.py29390%66–68
/home/runner/micromamba-root/envs/hyp3-isce2/lib/python3.11/site-packages/hyp3_isce2/metadata
   util.py14936%6–14, 18–21, 25–27
TOTAL69527261% 

Tests Skipped Failures Errors Time
34 0 💤 0 ❌ 0 🔥 1m 21s ⏱️

@cirrusasf cirrusasf marked this pull request as ready for review July 12, 2023 22:12
@cirrusasf cirrusasf requested a review from a team as a code owner July 12, 2023 22:12
Copy link
Contributor

@cirrusasf cirrusasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. I also test the water-mask branch locally, it works well. I approve this PR.

@asjohnston-asf asjohnston-asf merged commit 0a7d06c into develop Jul 12, 2023
9 checks passed
@asjohnston-asf asjohnston-asf deleted the water-mask branch July 12, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants