Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update time parsing in merge-tops-bursts.py #216

Merged
merged 8 commits into from
Jul 2, 2024

Conversation

jacquelynsmale
Copy link
Contributor

Update time parsing as suggested by issue 212.

@jacquelynsmale jacquelynsmale added the bug Something isn't working label Jun 28, 2024
@jacquelynsmale jacquelynsmale requested a review from a team as a code owner June 28, 2024 17:43
@jacquelynsmale jacquelynsmale marked this pull request as draft June 28, 2024 17:44
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
/home/runner/micromamba/envs/hyp3-isce2/lib/python3.11/site-packages/hyp3_isce2
   __main__.py26292%33, 44
   burst.py2505578%98–101, 114–119, 133–148, 164–173, 187–197, 255, 303–311, 331–345, 583–585, 611
   dem.py53394%101–110
   insar_stripmap.py694239%38–91, 95–97, 114–133
   insar_tops.py573047%49–87, 110–132
   insar_tops_burst.py23217823%91–163, 175–201, 231–314, 326–328, 341–439, 463–479, 515–599
   logger.py4175%9
   merge_tops_bursts.py6299585%184, 201, 263, 268, 325, 341, 349, 381, 385, 471, 498, 576, 616–634, 683–691, 715, 720, 779, 802, 946, 1129–1149, 1164–1177, 1191–1217, 1228–1231, 1236–1249, 1253
   s1_auxcal.py21290%51, 59
   slc.py341071%22–25, 29–34
   stripmapapp_alos.py50786%102, 138, 141–146
   topsapp.py70889%77, 107, 129–135
   utils.py2101095%114–125, 130, 236, 252–254, 261, 401, 446
   water_mask.py59592%88, 100–103
TOTAL179044875% 

Tests Skipped Failures Errors Time
85 0 💤 0 ❌ 0 🔥 32.705s ⏱️

@forrestfwilliams forrestfwilliams marked this pull request as ready for review July 1, 2024 21:01
@forrestfwilliams
Copy link
Contributor

I also added --overwrite to the gdal_calc.py call in water_mask.py. Without this, test_water_mask.py would fail if you had previously run the tests locally because it wasn't able to overwrite the generated test files.

@forrestfwilliams forrestfwilliams merged commit b09bfbb into develop Jul 2, 2024
8 checks passed
@forrestfwilliams forrestfwilliams deleted the merge-time-parse branch July 2, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants