Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use s1_orbits #228

Merged
merged 14 commits into from
Aug 9, 2024
Merged

Use s1_orbits #228

merged 14 commits into from
Aug 9, 2024

Conversation

jtherrmann
Copy link
Contributor

@jtherrmann jtherrmann commented Aug 8, 2024

TODO:

  • Don't install s1_orbits via pip in environment.yml after it's published to conda-forge
  • Test locally with before and after versions of the plugin and confirm the same orbit files are downloaded.
  • Squash merge to clean up the fact that I manually reverted changes across several files, which will make git blame ugly

@jtherrmann jtherrmann requested a review from a team as a code owner August 8, 2024 23:07
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Aug 8, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
/home/runner/micromamba/envs/hyp3-isce2/lib/python3.11/site-packages/hyp3_isce2
   __main__.py26292%33, 44
   burst.py2505578%98–101, 114–119, 133–148, 164–173, 187–197, 255, 303–311, 331–345, 583–585, 611
   dem.py53394%101–110
   insar_stripmap.py694239%38–91, 95–97, 114–133
   insar_tops.py533043%43–80, 101–121
   insar_tops_burst.py23017823%86–157, 169–195, 225–308, 320–322, 335–433, 457–473, 507–589
   logger.py4175%9
   merge_tops_bursts.py6299585%184, 201, 263, 268, 325, 341, 349, 381, 385, 471, 498, 576, 616–634, 683–691, 715, 720, 779, 802, 946, 1129–1149, 1164–1177, 1191–1217, 1228–1231, 1236–1249, 1253
   s1_auxcal.py21290%51, 59
   slc.py341071%22–25, 29–34
   stripmapapp_alos.py50786%102, 138, 141–146
   topsapp.py70889%77, 107, 129–135
   utils.py1921095%109–120, 125, 209, 225–227, 234, 374, 419
   water_mask.py59592%88, 100–103
TOTAL176644875% 

Tests Skipped Failures Errors Time
82 0 💤 0 ❌ 0 🔥 30.281s ⏱️

@jtherrmann jtherrmann marked this pull request as draft August 9, 2024 00:02
environment.yml Outdated Show resolved Hide resolved
@jtherrmann jtherrmann marked this pull request as ready for review August 9, 2024 16:41
@jtherrmann
Copy link
Contributor Author

Verified that python -m hyp3_isce2 ++process insar_tops_burst S1_136231_IW2_20200604T022312_VV_7C85-BURST S1_136231_IW2_20200616T022313_VV_5D11-BURST --looks 20x4 --apply-water-mask True downloads the same orbit files (same filenames and contents) on develop and s1-orbits.

@jtherrmann jtherrmann merged commit 9b4fe9d into develop Aug 9, 2024
8 checks passed
@jtherrmann jtherrmann deleted the s1-orbits branch August 9, 2024 17:45
mfangaritav added a commit to mfangaritav/hyp3-isce2 that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants