Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jth changes for multi burst #243

Merged
merged 3 commits into from
Aug 21, 2024
Merged

jth changes for multi burst #243

merged 3 commits into from
Aug 21, 2024

Conversation

jtherrmann
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Aug 21, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
/home/runner/micromamba/envs/hyp3-isce2/lib/python3.11/site-packages/hyp3_isce2
   __main__.py26292%33, 44
   burst.py2365577%97–100, 113–118, 132–147, 163–172, 186–196, 254, 302–310, 330–344, 543–545, 571
   dem.py53394%101–110
   insar_stripmap.py755033%38–101, 105–107, 122–139
   insar_tops.py875932%48–101, 132–182, 204–222
   insar_tops_burst.py1269227%66–137, 148–203, 215–244, 264–284
   logger.py4175%9
   merge_tops_bursts.py6299585%184, 201, 263, 268, 325, 341, 349, 381, 385, 471, 498, 576, 616–634, 683–691, 715, 720, 779, 802, 946, 1129–1149, 1164–1177, 1191–1217, 1228–1231, 1236–1249, 1253
   packaging.py19514327%46–48, 67–83, 120–218, 238–254, 274–284, 296–324, 336–338, 367–456, 460–466
   s1_auxcal.py21290%51, 59
   slc.py462057%23–30, 34–39, 50–56
   stripmapapp_alos.py50786%102, 138, 141–146
   topsapp.py70889%77, 107, 129–135
   utils.py2031095%109–120, 125, 226, 242–244, 251, 391, 436
   water_mask.py59592%88, 100–103
TOTAL190155271% 

Tests Skipped Failures Errors Time
82 0 💤 0 ❌ 0 🔥 33.925s ⏱️

Comment on lines -145 to +146
ref_dates = list(set([g[14:29] for g in reference]))
sec_dates = list(set([g[14:29] for g in secondary]))
ref_dates = list(set([g.split('_')[3] for g in reference]))
sec_dates = list(set([g.split('_')[3] for g in secondary]))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a style preference.

if len(ref_dates) > 1 or len(sec_dates) > 1:
raise ValueError('Reference granules must be from one date and secondary granules must be from one date.')

if not ref_dates[0] < sec_dates[0]:
if ref_dates[0] >= sec_dates[0]:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also just a style preference.

@jtherrmann jtherrmann marked this pull request as ready for review August 21, 2024 19:11
@jtherrmann jtherrmann requested a review from a team as a code owner August 21, 2024 19:11
@jtherrmann jtherrmann changed the title delete references to separate insar_tops_multi_burst workflow jth changes for multi burst Aug 21, 2024
@forrestfwilliams
Copy link
Contributor

Thanks!

@forrestfwilliams forrestfwilliams merged commit 7190c9e into simplify Aug 21, 2024
3 checks passed
@forrestfwilliams forrestfwilliams deleted the jth-changes branch August 21, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants