Create a new InSAR Stripmap workflow

[mfangaritav]

This PR is to include the stripmap workflow

[jtherrmann]

Hi @mfangaritav, thanks for the PR! I opened mfangaritav#1 with some minor fixes and general cleanup. If those changes look alright to you, feel free to approve and merge that PR. I will provide further feedback and suggestions as comments on this PR.

[jtherrmann]

Hi @mfangaritav before providing further feedback, it would be helpful for me to test the workflow on my local machine. Do you have a sample command that you've been running locally, that you could share with me? (Or you can just share the reference scene and secondary scene that you've been using for testing.)

[mfangaritav]

Hi @jtherrmann, thanks for looking at the PR. When I tried it locally I ran the command 'python -m hyp3_isce2 ++process insar_stripmap --username username --password password --reference-scene ALPSRP162831200 --secondary-scene ALPSRP156121200'. The username and password correspond to the asf account

[jtherrmann]

Thanks @mfangaritav! I'll run the command locally to get a better idea of what the workflow does.

[jtherrmann]

Hi @mfangaritav, sorry for the delayed response. I have some suggestions for how to simplify the insar_stripmap function. If you approve these changes, then I will likely have some follow-up suggestions for how to simplify the function further. I had one clarifying question regarding a reference to results[0] (see my feedback below) and I wanted to get your response before making further suggestions.

[mfangaritav]

Thanks for the suggestions. I committed the changes. Let me know if you have more suggestions or questions

[jtherrmann]

Hi @mfangaritav I opened another PR from my fork into yours: mfangaritav#2

This PR simplifies the insar_stripmap function and fixes the S3 uploading. I ran the workflow locally on my machine to confirm that it still produces the same output files.

[jtherrmann]

Hi @mfangaritav, I left a few more small suggestions. Otherwise, this PR looks good to me! I'm going to hand it over to @forrestfwilliams for final review and approval.

[jtherrmann]

Also, we should add a Changelog entry for the new workflow.

[mfangaritav]

Thank you so much for your input @jtherrmann.

[forrestfwilliams]

Various parts of this workflow assume that you are working with ALOS-1 data, even though stripmapApp can work with other datasets. I don't think this is a problem, but we should put something in the docstring here telling users that this is the case.

[mfangaritav]

At the moment, the only products from asf that I've been able to process with stripmap are the ALOS images. The products from ERS, Radarsat from asf are not compatible with ISCE for now.

[forrestfwilliams]

@mfangaritav this is looking pretty good to me. Could you add a test for stripmapappConfig similar to this?

[forrestfwilliams]

@mfangaritav Also a test for run_stripmapapp similar to this would be good.

[mfangaritav]

Sure @forrestfwilliams I'll work on the tests

[mfangaritav]

Hey @forrestfwilliams, sorry for the delay I was in a conference but I finally made the test for the stripmapApp process here. It super similar the tests for the topsApp process. I commented the last two lines because I do not know what monkeypatch refers to. Let me know if you have comments.

[jtherrmann]

Thanks @mfangaritav! Hopefully someone from our team will be able to help finalize this PR in the near future. Thanks for your patience!

[forrestfwilliams]

@mfangaritav sorry it took me so long to take a look at this, and @jtherrmann thank you for the reminder. The tests you added look good and I've left a suggested change to remove the two lines at the end of the second test that you commented out. Once we get this branch up-to-date with develop, I'm happy to approve.

[mfangaritav]

Thanks @forrestfwilliams!! I removed the lines

[forrestfwilliams]

Hey @mfangaritav, could you update the CHANGELOG.md 0.7.0 entry so that it looks like this?

## [0.7.0]
### Changed
* The naming convention for the burst products has been updated.
* InSAR stripmap workflow to support AVO's ALOS-1 processing efforts. This workflow is specific to AVO currently, and may not work for others.

Then we'll be ready to merge!

Mario has addressed his concerns

[mfangaritav]

Hi @forrestfwilliams, no problem, I've changed the CHANGELOG.md

[forrestfwilliams]

Merged! Thank you for being patient with us on this!