Update GPU dockerfile to fully support GPU workflow #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forrestfwilliams
changed the title
jtherrmann
reviewed
May 20, 2024
| ENV DEBIAN_FRONTEND=noninteractive | ||
|
|
||
| # FIXME: can remove git after switch back to released version of back-projection | ||
| RUN apt-get update && apt-get install -y --no-install-recommends unzip vim curl git build-essential gfortran libfftw3-dev && \ |
There was a problem hiding this comment.
This is standard for our plugins (see the cookiecutter Dockerfile). It's a pretty minimal package but provides of a lot of benefits when debugging within the container.
jtherrmann
reviewed
May 20, 2024
|
|
||
| # FIXME: can remove git after switch back to released version of back-projection | ||
| RUN apt-get update && apt-get install -y --no-install-recommends unzip vim curl git build-essential gfortran libfftw3-dev && \ | ||
| apt-get clean && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
Why rm -rf /var/lib/apt/lists/*?
There was a problem hiding this comment.
This removes unneeded apt metadata that serves no purpose other than bloating the container.
jtherrmann
reviewed
May 20, 2024
Comment on lines
+3
to
+4
| # MULTIARCH_DIR=/usr/lib/$(gcc -print-multiarch) | ||
| # FFTW_LIB=$MULTIARCH_DIR/libfftw3f.a |
There was a problem hiding this comment.
Are the commented-out lines still needed?
There was a problem hiding this comment.
Yeah, we may need to revert to this at some point, so I'd rather keep these close at hand.
jtherrmann
reviewed
May 20, 2024
jtherrmann
approved these changes
May 20, 2024
jtherrmann
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfile.gpuso that outputs will contain actual data.scripts/build_proc.shto combine GPU compilation steps.scripts/ubuntu_setup.shfor setting up a GPU-based Ubuntu EC2 AMI.README.mdto reflect the above changes.