Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute Envs Must be Imported to Render #2465

Merged
merged 23 commits into from
Oct 22, 2024
Merged

Conversation

AndrewPlayer3
Copy link
Contributor

@AndrewPlayer3 AndrewPlayer3 commented Oct 18, 2024

No description provided.

@AndrewPlayer3 AndrewPlayer3 added the bumpless Changes to documentation, CI/CD pipelines, etc that don't affect the project's version label Oct 18, 2024
@AndrewPlayer3 AndrewPlayer3 requested a review from a team as a code owner October 18, 2024 21:36
Copy link
Contributor

@jtherrmann jtherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing to APPS since it's not specific to render_cf.py

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
AndrewPlayer3 and others added 2 commits October 21, 2024 14:31
Co-authored-by: Jake Herrmann <[email protected]>
Co-authored-by: Jake Herrmann <[email protected]>
apps/render_cf.py Outdated Show resolved Hide resolved
apps/render_cf.py Outdated Show resolved Hide resolved
@jtherrmann jtherrmann merged commit d3afd83 into develop Oct 22, 2024
11 checks passed
@jtherrmann jtherrmann deleted the refactor-compute-envs branch October 22, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bumpless Changes to documentation, CI/CD pipelines, etc that don't affect the project's version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants