Fix issue with cloning CLIP repository #16614
Conversation
Related to AUTOMATIC1111#9774 Add network connectivity check and retry mechanism for `git_clone` function. * **launch.py** - Add a check for network connectivity before attempting to clone the repository. - Print a message and exit if the network connectivity check fails. * **modules/launch_utils.py** - Update the `git_clone` function to include a retry mechanism with a default of 3 retries. - Print a message and retry the clone operation if it fails, up to the specified number of retries. - Clean up the directory before retrying the clone operation.
There was a problem hiding this comment.
you should meke sure your line endings setting match what the repos uses so that it doesn't mark every line being modified
read https://github.com/AUTOMATIC1111/stable-diffusion-webui/wiki/Contributing
don't know why you deleted the PR checklist template
- I have read contributing wiki page
PR has to be based on and target dev branch, not master
|
|
||
| with launch_utils.startup_timer.subcategory("prepare environment"): | ||
| if not args.skip_prepare_environment: | ||
| if check_network_connectivity(): |
There was a problem hiding this comment.
this will not work
your change will prevent WebUI from launching if a user is disconnected from the internet or not able to reach GitHub for whatever reason
WebUI should be able to launch without a connection after it's installed and assets are downloaded
providing better more understandable error for git clone message makes more sense then adding a check_network_connectivity test
also you added some instructions on a user may set up a proxy
pretty much the only reason one would use a github proxy / morrir is because for whatever reason GitHub is unusable
but check_network_connectivity test you added will now work with proxy
preventing webui from launching
best that webui don't not make any unnecessary connections to any external servers including GitHub
Related to #9774
Add network connectivity check and retry mechanism for
git_clonefunction.launch.py
modules/launch_utils.py
git_clonefunction to include a retry mechanism with a default of 3 retries.